Ignore E2E test data for Git export #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes phpmyadmin#621 Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
williamdes
reviewed
Apr 1, 2025
| @@ -93,6 +94,10 @@ public function getErrorsAsArray($obj): array | |||
| */ | |||
| public function getData(string $name): array | |||
| { | |||
| if (! file_exists('tests/data/' . $name . '.out')) { | |||
There was a problem hiding this comment.
I think this would be too risky for new tests to have missing data
can you check in setUp() if the folder exists?
There was a problem hiding this comment.
There some test classes that have more than e2e tests, so skipping in setUp() will also skip valid tests that do not depend on that.
There was a problem hiding this comment.
The best option is to refactor the tests, but I don't know how much refactoring is needed. I already attempted changing those tests (#598), but I'm yet to find a good solution.
There was a problem hiding this comment.
Okay, can you turn the phpunit to error when there is skipped tests on the CI?
I think that will be a good safety measure
Or use incomplete instead of skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can work on
masterbranch a way of extracting these tests and run them separately.