Skip to content

Commit 1a0544c

Browse files
committed
[BCB] Constructor parameter $isReference in TypelessParamTagValueNode made required
1 parent be3aafa commit 1a0544c

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

Diff for: UPGRADING.md

+1
Original file line numberDiff line numberDiff line change
@@ -119,3 +119,4 @@ The line with `some text in the middle` in phpdoc-parser 2.0 is now part of the
119119
* Constructor parameter `$isEquality` in `AssertTag*ValueNode` made required
120120
* Constructor parameter `$templateTypes` in `MethodTagValueNode` made required
121121
* Constructor parameter `$isReference` in `ParamTagValueNode` made required
122+
* Constructor parameter `$isReference` in `TypelessParamTagValueNode` made required

Diff for: src/Ast/PhpDoc/TypelessParamTagValueNode.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class TypelessParamTagValueNode implements PhpDocTagValueNode
1919
/** @var string (may be empty) */
2020
public string $description;
2121

22-
public function __construct(bool $isVariadic, string $parameterName, string $description, bool $isReference = false)
22+
public function __construct(bool $isVariadic, string $parameterName, string $description, bool $isReference)
2323
{
2424
$this->isReference = $isReference;
2525
$this->isVariadic = $isVariadic;

Diff for: tests/PHPStan/Parser/PhpDocParserTest.php

+2
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ public function provideTypelessParamTagsData(): Iterator
539539
false,
540540
'$foo',
541541
'description',
542+
false,
542543
),
543544
),
544545
]),
@@ -570,6 +571,7 @@ public function provideTypelessParamTagsData(): Iterator
570571
true,
571572
'$foo',
572573
'description',
574+
false,
573575
),
574576
),
575577
]),

0 commit comments

Comments
 (0)