Match Rule Descriptions with Configuration Parameters in README.md #265
Conversation
README.md
Outdated
| | | Check LSP even for static methods. | | ||
| | `requireParentConstructorCall` | Require calling parent constructor. | | ||
| | `disallowedBacktick` | Disallow usage of backtick operator (`` $ls = `ls -la` ``). | | ||
| | `closureUsesThis` | Closure should use `$this` directly instead of using `$this` variable indirectly. | |
There was a problem hiding this comment.
Would be nice if the table was also formatted nicely in markdown.
|
Unfortunately it's still not very readable.
|
|
A note: use spaces instead of tabs and IntelliJ/PHPStorm/... can this format automatically. |
|
@ondrejmirtes Okay, I can fix it. Given the issues so far, I just want to confirm if everyone is happy with a table format. See screenshot below... there will be a horizontal scroll bar. Alternatively, I can list each rule description with the parameter as the header. Let me know your thoughts. Cc @hrach |
|
Would be better if the text in the 2nd column wrapped instead of causing horizontal scrolling. |
|
Please solve the conflict, there was a new parameter added meanwhile. |
OsitaDNU
force-pushed
the
improve-rule-descriptions
branch
from
67a405b to
3ecc310
Compare
|
Hi, I've fixed the conflict. Should be good to go now. Thanks |
|
Thank you! |
Hi,
I watched your video on stricter rules in PHPStan and wanted to configure the rules I needed. However, I found it difficult to match the configuration parameters to their corresponding rule descriptions. I also checked the documentation but couldn’t find where these parameters were defined.
To improve clarity, I’ve put the rule descriptions into a table and tried to match them with their respective configuration parameters. This should make it easier to understand which settings control each rule.
However, I couldn’t match the following parameters to any rule descriptions:
uselessCastdisallowedImplicitArrayCreationstrictArrayFilterillegalConstructorMethodCallAdditionally, I couldn’t match the following rule descriptions to a specific parameter:
Could you review my matches to ensure they are correct? Also, any help in completing the missing mappings would be appreciated. Thanks!