Skip to content

[Feature Request] Enforce ResetInterface on non-read-only services #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
priyadi opened this issue Feb 20, 2024 · 2 comments
Closed

[Feature Request] Enforce ResetInterface on non-read-only services #380

priyadi opened this issue Feb 20, 2024 · 2 comments

Comments

@priyadi
Copy link

priyadi commented Feb 20, 2024

I'm proposing this rule: if a class is in the container, then it must either be read-only/immutable, or implement ResetInterface.

This rule will help to ensure our code is ready for worker mode (Swoole, FrankenPHP, RoadRunner, etc).

@ondrejmirtes
Copy link
Member

Hello, this is too opinionated because traditional apps don't need it.

But you can always implement a custom rule (and even publish it as your own package) 😊

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants