Skip to content

Use stubfile extension for PasswordUpgraderInterface #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Use stubfile extension for PasswordUpgraderInterface #335

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f701a3
Use stubfile extension for PasswordUpgraderInterface
VincentLanglet Feb 19, 2023
f961a75
Use interface_exists
VincentLanglet Feb 19, 2023
ce7182c
Update stub file extensions checks
VincentLanglet Feb 20, 2023
c12047b
Bump phpstan
VincentLanglet Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extension.neon
View file
Original file line number Diff line number Diff line change
@@ -58,8 +58,6 @@ parameters:
- stubs/Symfony/Component/Security/Core/Authentication/Token/TokenInterface.stub
- stubs/Symfony/Component/Security/Core/Authorization/Voter/Voter.stub
- stubs/Symfony/Component/Security/Core/Authorization/Voter/VoterInterface.stub
- stubs/Symfony/Component/Security/Core/User/PasswordAuthenticatedUserInterface.stub
- stubs/Symfony/Component/Security/Core/User/PasswordUpgraderInterface.stub
- stubs/Symfony/Component/Serializer/Encoder/ContextAwareDecoderInterface.stub
- stubs/Symfony/Component/Serializer/Encoder/DecoderInterface.stub
- stubs/Symfony/Component/Serializer/Encoder/EncoderInterface.stub
@@ -298,6 +296,10 @@ services:
class: PHPStan\Symfony\InputBagStubFilesExtension
tags:
- phpstan.stubFilesExtension
-
class: PHPStan\Symfony\PasswordAuthenticatedUserStubFilesExtension
tags:
- phpstan.stubFilesExtension

# FormInterface::getErrors() return type
-
23 changes: 23 additions & 0 deletions src/Symfony/PasswordAuthenticatedUserStubFilesExtension.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php declare(strict_types = 1);

namespace PHPStan\Symfony;

use PHPStan\PhpDoc\StubFilesExtension;
use function interface_exists;

class PasswordAuthenticatedUserStubFilesExtension implements StubFilesExtension
{

public function getFiles(): array
{
if (!interface_exists('Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime concerns are irrelevant for PHPStan, you need to ask ReflectionProvider. If ReflectionProvider cannot be injected, then ask Reflector, as phpstan-doctrine does: https://github.com/phpstan/phpstan-doctrine/blob/1.3.x/src/Stubs/Doctrine/StubFilesExtensionLoader.php

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I understand anything about PHPStan internals, but isn't that the "same" as in : https://github.com/phpstan/phpstan-symfony/blob/1.2.x/src/Symfony/InputBagStubFilesExtension.php#L13 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is reaaaaaally old and should be fixed too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for both StubFilesExtension.

return [];
}

return [
__DIR__ . '/../../stubs/Symfony/Component/Security/Core/User/PasswordAuthenticatedUserInterface.stub',
__DIR__ . '/../../stubs/Symfony/Component/Security/Core/User/PasswordUpgraderInterface.stub',
];
}

}