Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg_config: command not found and missing magic block #11

Closed
zheka-13 opened this issue Jul 27, 2017 · 2 comments
Closed

pg_config: command not found and missing magic block #11

zheka-13 opened this issue Jul 27, 2017 · 2 comments

Comments

@zheka-13
Copy link

Hi,
When postgresql compiled from source and installed into default dirs pg_config not accessible from PATH. My suggestion below. One can easily change pg_config location in Makefile and there won't be no warnings.
I suggest to modify Makefile:

  1. Instead of
    PGXS := $(shell pg_config --pgxs)
    do
    PG_CONFIG = pg_config
    PGXS := ( s h e l l (PG_CONFIG) --pgxs)
  2. Add OBJS = zson.o. I don't understand why it's removed. Without it i can compile extension but get error when try to install it
    incompatible library "/usr/local/pgsql/lib/zson.so": missing magic block
@afiskon
Copy link
Collaborator

afiskon commented Jul 27, 2017

OK, I can confirm (2). Thanks a lot for reporting this. Fixed in 3d89ce8 CC: @arssher

I can't tell that I fully agree with (1) though. If pg_config is not in PATH it means that psql and other tools are not too. This is very atypical installation to say the least.

@afiskon afiskon closed this as completed Jul 27, 2017
@arssher
Copy link
Contributor

arssher commented Jul 27, 2017

2) Sorry, this is my fault: recently I have cleaned the Makefile, but forgot to remove MODULE_big var from it. See the following pull request where it is explained in the detail:
#12

1) I support the idea: the situation in which you use for development several custom-built postgres'es is not rare. However, your solution is not good because it requires manual changes in the Makefile. In my pull request I improved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants