-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startsWith and endsWith #147
base: master
Are you sure you want to change the base?
Add startsWith and endsWith #147
Conversation
This is because like `stripPrefix` and `stripSuffix`, these functions are CodeUnit/CodePoint-agnostic. The same was also done for tests.
Please, don't fix older commits in newer ones A problem introduced by commit X should be fixed in commit X, otherwise reviewing the code becomes very hard, as well as reading the git history after this gets merged. See also this post from Linux HID subsystem and libinput maintainer Peter Hutterer. Despite the post age it's well relevant today, "old but gold". |
@Hi-Angel thanks for the advice, but i'm not interested in purescript anymore (i haven't used it in years), feel free to take this up if you'd like |
Description of the change
Add
startsWith
andendsWith
functions toData.String.CodeUnits
.Fixes #127.
I know that there's still a bit of disagreement over whether this should be done or not, but I just opened this PR because it didn't take a lot of time. If it's ultimately decided against, feel free to close this PR.
To do:
stripPrefix
andstripSuffix
stripPrefix
andstripSuffix
Data.String.NonEmpty
Checklist: