Skip to content
This repository was archived by the owner on Nov 23, 2017. It is now read-only.

Use staticmethod or module function when instance isn't referenced. #436

Closed

Conversation

JustinTArthur
Copy link

I used staticmethods where I thought the taxonomy or overridability might be useful, or I didn't know.

I used staticmethod where I thought the taxonomy or overridability might be useful, or I didn't know.
@Martiusweb
Copy link
Member

Hi,

Do you have a use case where overriding those functions is useful?
Imho, since those functions and methods are private, and unless there is a good use case inside the codebase of asyncio, we shouldn't encourage someone to override them.

@gvanrossum
Copy link
Member

This looks like a refactoring that accomplishes nothing except code churn. Let's not do this.

@gvanrossum gvanrossum closed this Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants