This repository was archived by the owner on Nov 23, 2017. It is now read-only.
starttls: Add "call_connection_made" arg to SSLProtocol.__init__ #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gvanrossum Are you OK with me merging this in 3.6 beta 2? |
|
Yes, LGTM. |
|
Thanks! Merged by hand in d4abdd5. I'll make a PyPI package for starttls soon. Hopefully, this PR is enough (my current understanding is that it should be). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the key modification of
sslproto.pyrequired to implement starttls. With this patch in place, we can implement starttls as an external package without copying/pasting ofsslproto.py.The patch is super small and non-invasive, only adding an extra argument to
SSLProtocol.__init__(everything insidesslproto.pyis an implementation detail of asyncio).