Skip to content

gh-133982: Use implementation-specific open in test_fileio OtherFileTests #135364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmaloney
Copy link
Contributor

@cmaloney cmaloney commented Jun 10, 2025

The tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly with an encoded name.

For the append tests it looks like FileIO directly is closer to what was intended, there is test_io that has append tests around self.open directly, this is test_fileio so intent I think was to test FileIO directly.

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 16, 2025
@efimov-mikhail
Copy link
Contributor

efimov-mikhail commented Jun 16, 2025

Is it worth backporting on 3.13? cc @Yhg1s

P.S. Congratulations with becoming Core Dev, @ZeroIntensity !!!

@ZeroIntensity
Copy link
Member

We've been backporting these to 3.13 as far as I can tell.

@cmaloney
Copy link
Contributor Author

Not sure policy: Is a test-only change which enables more testing of _pyio, a _io implementation CPython doesn't use directly at the moment.

The work I'm doing on top of these patches is adding another _io.Buffered* implementation which is runtime switchable, starting in a copy/paste of _io, new import that swaps implementation to ease side by side performance testing/integrating while having a working/building/running CPython. Hoping to land the feature in the 3.15 feature window, but lots of steps to get there (implementation, creating I/O benchmarks in pyperformance, testing compatibility, validating performance on range of systems, PEP, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants