Skip to content

gh-135429: Fix the argument mismatch in lsprof throw event #135442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Jun 12, 2025

PY_THROW event has a different signature than PY_START. We changed the interface to argument clinic and ignored the difference. It would've been caught but the test case was changed from another PR.

This PR fixes the issue and refreshes the testcase.

@gaogaotiantian gaogaotiantian added the needs backport to 3.14 bugs and security fixes label Jun 12, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

…ch75_.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@gaogaotiantian gaogaotiantian merged commit b03309f into python:main Jun 12, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@gaogaotiantian gaogaotiantian deleted the fix-lsprof-throw-event branch June 12, 2025 21:46
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2025
…honGH-135442)

(cherry picked from commit b03309f)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 12, 2025

GH-135446 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 12, 2025
gaogaotiantian added a commit that referenced this pull request Jun 12, 2025
…-135442) (#135446)

gh-135429: Fix the argument mismatch in lsprof throw event (GH-135442)
(cherry picked from commit b03309f)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants