-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135429: Fix the argument mismatch in lsprof throw event #135442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gaogaotiantian
merged 3 commits into
python:main
from
gaogaotiantian:fix-lsprof-throw-event
Jun 12, 2025
Merged
gh-135429: Fix the argument mismatch in lsprof throw event #135442
gaogaotiantian
merged 3 commits into
python:main
from
gaogaotiantian:fix-lsprof-throw-event
Jun 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Jun 12, 2025
ZeroIntensity
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
Misc/NEWS.d/next/Library/2025-06-12-18-15-31.gh-issue-135429.mch75_.rst
Outdated
Show resolved
Hide resolved
…ch75_.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2025
…honGH-135442) (cherry picked from commit b03309f) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
GH-135446 is a backport of this pull request to the 3.14 branch. |
gaogaotiantian
added a commit
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PY_THROW
event has a different signature thanPY_START
. We changed the interface to argument clinic and ignored the difference. It would've been caught but the test case was changed from another PR.This PR fixes the issue and refreshes the testcase.