gh-135447: Update dis.rst to reflect 3.14 bytecode instructions #135478
Conversation
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
Ragna1204
changed the title
Ragna1204
changed the title
Ragna1204
changed the title
Is it correct link? |
|
|
||
| .. versionadded:: 3.14 | ||
|
|
||
|
|
There was a problem hiding this comment.
Why this have been removed from Unary operations section?
There was a problem hiding this comment.
I removed it because it was causing conflict in a check as it was mentioned twice. If its better then i can re add this here and remove the other mention
| ``CALL_FUNCTION_EX`` pops all arguments and the callable object off the stack, | ||
| calls the callable object with those arguments, and pushes the return value | ||
| calls the callable with those arguments, and pushes the return value |
There was a problem hiding this comment.
Is it better without "object" word?
|
Could you please provide here links to the exact PRs when these bytecodes are introduced? |
|
I feel like this PR was AI-generated. Either that or it is misguided. Most of the documentation here is factually incorrect. Sorry in advance if the PR was not AI generated. |
|
Hi @efimov-mikhail and @Fidget-Spinner , sorry i was not focusing while writing the PR and added the link tag from some other project contribution i was doing. Thanks for pointing it out, i have fixed it now |
But for now it's just a link for this PR itself. |
|
I'm really sorry but I'm closing this PR. I suspect while it's not AI written, AI might have been used while sourcing the changes to the bytecode. While I recommend AI usage for things like grammar and sentence structure, it's not an accurate nor reliable source to use. Even if not AI-sourced, the content is almost entirely factually inaccurate, that it would take as much effort for me to rewrite the PR as to open a PR myself. I'm really sorry again. Please let me know if you think I was mistaken somewhere. |
This pull request fixes #135478 by:
dis.rst.CALL_FUNCTION_EXopcode's description to reflect its 3.14 semantics.The following instructions were added:
BUILD_INTERPOLATIONLOAD_SMALL_INTNOT_TAKENThis change brings the dis docs up to date with the 3.14 implementation.
See #135478 for more context.
📚 Documentation preview 📚: https://cpython-previews--135478.org.readthedocs.build/
dismodule docs #135447