-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135496: Fix f string exclamation mark error typo #135495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-135496: Fix f string exclamation mark error typo #135495
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core change looks good to me, but please make an issue and blurb entry for posterity.
Misc/NEWS.d/next/Core_and_Builtins/2025-06-14-01-01-14.gh-issue-135496.ER0Me3.rst
Outdated
Show resolved
Hide resolved
…e-135496.ER0Me3.rst Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Thanks @MeGaGiGaGon for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, @MeGaGiGaGon and @terryjreedy, I could not cleanly backport this to
|
GH-135499 is a backport of this pull request to the 3.14 branch. |
@MeGaGiGaGon Can you prepare a 3.13 backport? The comment on the make-a-PR page details how to adjust the title and message. Make sure to prepare using 3.13 branch and compare to 3.13 on the make-a-PR page. If you do not understand, I can fix but wrong title will be a test error. Both lines to be corrected are 10 lines earlier, but this is not the issue. The merge conflict is that on the crossinterp.c lines, what is 'c-string' now and in 3.14 is 'f- string' in 3.13. So make same 2 changes on otherwise same 2 lines. I consider the blurb for a typo to be optional. |
|
GH-135501 is a backport of this pull request to the 3.13 branch. |
Typo fix, the error has "exclamanation" instead of "exclamation"