Truncate pipeline exception message to a sane size #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rohansingh thank you for your contribution! Your change will be reviewed soon. |
akx
reviewed
Feb 26, 2025
rohansingh
force-pushed
the
truncate-pipeline-exception
branch
from
17a16c6 to
2778765
Compare
|
|
@rohansingh Hi! Looks like some cluster tests are still failing |
|
Sorry, I've had trouble getting the cluster tests to run in my dev environment for some reason. Will take a look in a bit. |
petyaslavova
reviewed
Mar 4, 2025
petyaslavova
reviewed
Mar 4, 2025
petyaslavova
requested changes
Mar 7, 2025
|
LGTM, just need to resolve conflicts and fix tests |
|
Yup sorry about the delay, I will get to this today! I appreciate the prompt reviews. |
rohansingh
force-pushed
the
truncate-pipeline-exception
branch
from
4599a56 to
0bd8365
Compare
petyaslavova
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Hi @rohansingh , linters are failing and I have one more small request to rename the new function. It can truncate any text and we can use it for other purposes as well.
For the linters, have in mind that we have updated the tooling recently and you might need install again the dev dependencies.
excitoon
reviewed
Mar 13, 2025
* skip `ssl` import if not available Signed-off-by: Joel Dice <joel.dice@fermyon.com> * address review feedback and fix lint errors Signed-off-by: Joel Dice <joel.dice@fermyon.com> * remove TYPE_CHECKING clause from ssl conditional Signed-off-by: Joel Dice <joel.dice@fermyon.com> --------- Signed-off-by: Joel Dice <joel.dice@fermyon.com> Co-authored-by: petyaslavova <petya.slavova@redis.com>
…ameter. Updating pipeline infra (redis#3564) * Fixing search module dropindex function not to send invalid third parameter. Updating pipeline infra * Fixing linters
* fix: add TimeoutError handling in get_connection() In get_connection() we can implicitly call read on a connection. This can timeout of the underlying TCP session is gone. With this change we remove it from the connection pool and get a new connection. * fix: add TimeoutError handling in get_connection() sync/async In get_connection() we can implicitly call read on a connection. This can timeout of the underlying TCP session is gone. With this change we remove it from the connection pool and get a new connection. * fix: update version number to match test expectations * fix: revert version number to 5.2.1, manually uninstall entraid
…cement for 'read_from_replicas' config) (redis#3563) * Adding laod balancing strategy configuration to cluster clients(replacement for 'read_from_replicas' config) * Fixing linter errors * Changing the LoadBalancingStrategy type hints to be defined as optional. Fixed wording in pydocs * Adding integration tests with the different load balancing strategies for read operation * Fixing linters
petyaslavova
approved these changes
Mar 25, 2025
vladvildanov
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3491.