Fix bug that could cause errors not to be reported when on last line. fixes microsoft#20

Author: mjbvz

e2e/tests/errors.js

@@ -92,4 +92,27 @@ describe('Errors', () => {
             assert.strictEqual(error.end.offset, 59);
         });
     });
+
+    it('should return error for multiline unknown property #20', () => {
+        const server = createServer();
+        openMockFile(server, mockFileName, [
+            'function css(x) { return x; };',
+            'const q = css`',
+            'boarder: 1px solid black;',
+            '`'
+            ].join('\n'));
+        server.send({ command: 'semanticDiagnosticsSync', arguments: { file: mockFileName } });
+
+        return server.close().then(() => {
+            const errorResponse = getFirstResponseOfType('semanticDiagnosticsSync', server);
+            assert.isTrue(errorResponse.success);
+            assert.strictEqual(errorResponse.body.length, 1);
+            const error = errorResponse.body[0];
+            assert.strictEqual(error.text, 'Unknown property.');
+            assert.strictEqual(error.start.line, 3);
+            assert.strictEqual(error.start.offset, 1);
+            assert.strictEqual(error.end.line, 3);
+            assert.strictEqual(error.end.offset, 8);
+        });
+    });
 })

src/styled-template-language-service.ts

@@ -120,7 +120,7 @@ export default class StyledTemplateLanguageService implements TemplateLanguageSe
         doc: vscode.TextDocument,
         context: TemplateContext,
         content: string
-    ) {
+    ) {        
         const sourceFile = context.node.getSourceFile();
         return diagnostics.map(diag =>
             this.translateDiagnostic(diag, sourceFile, doc, context, content));
@@ -132,10 +132,10 @@ export default class StyledTemplateLanguageService implements TemplateLanguageSe
         doc: vscode.TextDocument,
         context: TemplateContext,
         content: string
-    ): ts.Diagnostic | undefined {
+    ): ts.Diagnostic | undefined {        
         // Make sure returned error is within the real document
         if (diagnostic.range.start.line === 0
-            || diagnostic.range.start.line >= doc.lineCount
+            || diagnostic.range.start.line > doc.lineCount
             || diagnostic.range.start.character >= content.length
         ) {
             return undefined;