feat: always show list of features on cargo add
#15658
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #15524
What does this PR try to resolve?
Currently, cargo shows list of features available for the package added only when features specified correctly. In turn, if the features specified by
cargo add --features
doesn't exist (at least for the version specified in Cargo.toml), it just bails with "unrecognized feature(s)" error.This PR modifies the timing of
print_dep_table_msg()
so that it's always called.How to test and review this PR?
The changes of UI can be observed by peeking the modified SVGs. I think those changes make sense, however there might be different opinions.