Skip to content

prev_page field is always null on search #10349

Open
@GuillaumeGomez

Description

@GuillaumeGomez
Member

Current Behavior

prev_page is always null.

Expected Behavior

It should return the seek for the previous page if there is one.

Steps To Reproduce

You can see the issue on docs.rs:

Go to https://docs.rs/releases/search?query=sysinfo
Click "next page"

Then you can see that there is no "previous page" button. I originally suspected a bug on docs.rs side but after investigating, it looks like the ["api", "v1", "crates"] query always return a null prev_page in the JSON response.

Environment

No response

Anything else?

No response

Activity

Turbo87

Turbo87 commented on Jan 8, 2025

@Turbo87
Member

That's intended behavior. The way seek pagination is implemented we can't offer reverse traversal without sacrificing performance.

GuillaumeGomez

GuillaumeGomez commented on Jan 8, 2025

@GuillaumeGomez
MemberAuthor

I see. I suppose we can store the previous page in the cookie session... Gonna find something out.

eth3lbert

eth3lbert commented on Jan 9, 2025

@eth3lbert
Contributor

That's intended behavior. The way seek pagination is implemented we can't offer reverse traversal without sacrificing performance.

I don't expect significant performance issues. It would only involve some reverse handling (including query and result processing). This is actually one of the enhancement items on my backlog.

self-assigned this
on Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-backend ⚙️C-enhancement ✨Category: Adding new behavior or a change to the way an existing feature works

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Turbo87@eth3lbert@GuillaumeGomez

    Issue actions

      `prev_page` field is always `null` on search · Issue #10349 · rust-lang/crates.io