Skip to content

Fix match_single_binding wrongly handles scope #15060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix match_single_binding wrongly handles scope #15060

wants to merge 2 commits into from
+505 −71

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 15, 2025 •
edited
Loading

Closes #15018
Closes #15269

Continuation of #15017

changelog: [match_single_binding] fix wrong handling of scope

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 15, 2025
dswij
dswij reviewed Jun 22, 2025
View reviewed changes
@profetia profetia requested a review from dswij June 24, 2025 13:24
@samueltardieu samueltardieu mentioned this pull request Jun 29, 2025
Open
@profetia
Copy link
Contributor Author

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned dswij Jun 30, 2025
@profetia
Copy link
Contributor Author

I will try also include fixes for #15162

@samueltardieu
Copy link
Member

Reverting unsollicited reassignment
r? dswij

@rustbot rustbot assigned dswij and unassigned samueltardieu Jun 30, 2025
@profetia profetia force-pushed the issue15018 branch 2 times, most recently from 98b8c4b to fce7326 Compare July 5, 2025 09:05
@profetia profetia requested a review from samueltardieu July 5, 2025 09:07
@antonilol antonilol mentioned this pull request Jul 13, 2025
Open
@samueltardieu
Copy link
Member

This doesn't seem to fix #15269 which is of the same category. Could you have a look @profetia?

@profetia
Copy link
Contributor Author

@samueltardieu #15269 is fixed in this PR now

dswij
dswij reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, it looks great! Just a small comment, and I think it's good to merge afterward.

@profetia
Copy link
Contributor Author

Updated. Thank you!

@profetia profetia requested a review from dswij July 17, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu

@dswij dswij

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match_single_binding suggests code with invalid syntax match_single_binding: missing brackets
4 participants
@profetia @rustbot @samueltardieu @dswij