Skip to content

or_fun_call: lint method calls inside map_or first arg #15074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 18, 2025

blocked on #15073

Lint method calls inside map_or too, so for this, lint will be showed:

Some(4).map_or("asd".to_string().len() as i32, f);

previously it worked only for:

Some(4).map_or(slow_fun(), f);

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2024&gist=bfcda42a6af446e69bc883a8b45eb13c

Sorry for multiple or_fun_call PRs.

changelog: [or_fun_call]: lint method calls inside map_or first arg

@klensy klensy force-pushed the or-fun-call-more branch 2 times, most recently from 85eed3d to af7625a Compare June 21, 2025 09:57
@klensy
Copy link
Contributor Author

klensy commented Jun 22, 2025

Okay, review last 3 commits please and I'll rebase this pr or #15073, depending on who will be first.

@klensy klensy marked this pull request as ready for review June 22, 2025 09:56
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025
@llogiq
Copy link
Contributor

llogiq commented Jul 6, 2025

I merged the other improvement, please rebase.

@klensy klensy force-pushed the or-fun-call-more branch from af7625a to 86a1496 Compare July 6, 2025 15:45
@klensy
Copy link
Contributor Author

klensy commented Jul 6, 2025

I merged the other improvement, please rebase.

done.

@llogiq llogiq added this pull request to the merge queue Jul 10, 2025
@llogiq
Copy link
Contributor

llogiq commented Jul 10, 2025

Thank you!

Merged via the queue into rust-lang:master with commit df5a0ee Jul 10, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants