Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build fails #1621

Closed
TornaxO7 opened this issue Dec 14, 2023 · 2 comments
Closed

CI Build fails #1621

TornaxO7 opened this issue Dec 14, 2023 · 2 comments

Comments

@TornaxO7
Copy link
Contributor

If you take a look into the different PRs their CI is failing due to build.rs and some network issue. Is there a solution to this?

@rxst
Copy link

rxst commented Dec 14, 2023

Yes, we need to fix the parsing of request URLs. So for PR some failed checks were because the URLs parsed wrong. They URLs like https://api.github.com/repos/lucid-kv/lucid, so comma in end break URL.
But in most cases, we have 403 so we probably need a different user for checks.

Screenshot 2023-12-14 at 14 00 41

@palfrey
Copy link
Collaborator

palfrey commented Dec 29, 2023

The 403s are mostly due to Github hitting rate limits because we chek. Repos are only checked once per week and in theory if the main branch was edited fairly recently then PRs should use the cached checks from that. main branch checks also have an actual user credential applied to them (which we can't use on PRs, or people would be able to abuse it).

#1628 fixes all the current ones. PRs in the future to fix things before I get the time to look at them would be most appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants