Don't cache WebSocket request in RequestCache #16741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuezk
added a commit
to yuezk/spring-security
that referenced
this pull request
Mar 16, 2025
PR spring-projectsgh-16741 Signed-off-by: Kevin Yue <yuezk001@gmail.com>
yuezk
force-pushed
the
not_save_websocket_request
branch
from
2340aeb to
09f8287
Compare
spring-projects-issues
added
the
status: waiting-for-triage
PR spring-projectsgh-16741 Signed-off-by: Kevin Yue <yuezk001@gmail.com>
yuezk
force-pushed
the
not_save_websocket_request
branch
from
09f8287 to
e67bd91
Compare
yuezk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebSocket connection request should not be cached. Since it doesn't accept a custom header, we cannot use
X-Requested-Withas the workaround. Instead, we can match theUpgrade: websocketheader and ignore it by default.