Skip to content

Fix typescript support #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2017
Merged

Fix typescript support #36

merged 2 commits into from
Apr 9, 2017

Conversation

kayahr
Copy link
Contributor

@kayahr kayahr commented Mar 31, 2017

Description

A TypeScript definition is included in the source repository but it is not included in the published package (See #33). This pull request references the definition in the package.json so it is included in the package and it is no longer necessary to depend on the external @types/error-stack-parser package.

This PR also adds an export line into the definition so it is possible to import the library properly with ES6 syntax:

import * as ErrorStackParser from "error-stack-parser";

const frames = ErrorStackParser.parse(new Error("Message"));

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

@eriwen
Copy link
Member

eriwen commented Apr 9, 2017

Excellent, thanks!

@eriwen eriwen merged commit 9803354 into stacktracejs:master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants