Skip to content

Fix CI 🤞 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2018
Merged

Fix CI 🤞 #43

merged 2 commits into from
May 29, 2018

Conversation

bengourley
Copy link
Contributor

The CI was not working in my other PR (#42). This is an attempt to fix it!

Update the SauceLabs configuration for updates to the their service.
The have now removed ALL versions of Opera and don't appear to support
any iOS versions before 9.3.

There is a transient dependency on sqlite3 which does not build on
Travis because the sqlite3 node module does not yet support node 10
and the Travis build runs on the latest "stable" node, which is
currently 10. I specified node 8 in .travis.yml.
@bengourley
Copy link
Contributor Author

After the successful build, I merged this into #42.

I tried to do the most minimal changeset to get things working, however it did raise a question…

The jsdoc-dash-template dependency (which depends on sqlite3, which was at the root of the majority of the issues) doesn't appear to be used by any script or command included in the repository. I can see that it is referenced in jsdoc.conf.json but that file doesn't appear to be consumed/used by anything as far as I can see. Should jsdoc-dash-template, jsdoc.conf.json and thus sqlite3 be removed?

@bengourley bengourley merged commit 78f860f into stacktracejs:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant