Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Raise importance of global vs local transitions #15479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

midzelis
Copy link

I got caught up wondering why my transition wasn't working - and it was because I needed a global transition. As currently written, the sentence:

A transition is triggered by an element entering or leaving the DOM as a result of a state change.

Makes it sound like transitions are always triggered by elements entering/leaving the DOM - however, that is only true for global transitions, which are not the default. I took a stab at clarifying this, and raising the importance of this by moving up the local/global section to the first paragraph. I created a dedicated section for 'Global Transitions' which contains the example, and I added an explanation of how to actually specify |global

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 80d9878

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants