Skip to content

KafkaAcknowledgedMessage lacks headers #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blindspotbounty opened this issue Nov 13, 2023 · 1 comment · Fixed by #179
Closed

KafkaAcknowledgedMessage lacks headers #144

blindspotbounty opened this issue Nov 13, 2023 · 1 comment · Fixed by #179
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.

Comments

@blindspotbounty
Copy link
Collaborator

We use kafka headers to store technical information about message.
However, it was surprising that there are no headers in KafkaAcknowledgedMessage.

Could you advise whether there are plans to add it at some point, please?
@FranzBusch
Copy link
Contributor

I think we can easily add this. We just need to parse the headers out of the underlying rd message pointer. Feel free to open a PR.

@FranzBusch FranzBusch added the good first issue Good for newcomers label Nov 17, 2023
@FranzBusch FranzBusch added the kind/enhancement Improvements to existing feature. label Oct 31, 2024
@malletgu malletgu mentioned this issue Nov 15, 2024
Merged
FranzBusch pushed a commit that referenced this issue Nov 15, 2024
@malletgu @mimischi
Add headers to KafkaAcknowledgedMessage (#179)
Loading
Loading status checks…
09aca6b 
When a message is being sent to Kafka the acknowledgement should also
contains the headers.

### Motivation:

Resolves #144

### Modifications:

Reused the parsing function from KafkaConsumer in the producer path to
return headers in the ack.

### Result:

Headers available in the acknowledgement for producers and still
available for consumers as well.

---------

Co-authored-by: Michael Gecht <gecht@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add headers to KafkaAcknowledgedMessage malletgu/swift-kafka-client
2 participants
@FranzBusch @blindspotbounty