[Distributed] Carry SPI attribute to stub types #79987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
commented
Mar 13, 2025
| @@ -133,6 +137,9 @@ extension DistributedResolvableMacro { | |||
| var isGenericOverActorSystem = false | |||
| var specificActorSystemRequirement: TypeSyntax? | |||
|
|
|||
| let attributes = proto.attributes.filter { attr in | |||
| attr.as(AttributeSyntax.self)?.attributeName.trimmed.description == "_spi" | |||
There was a problem hiding this comment.
@ahoppen would you mind helping me out what a better way to spell this is?
There was a problem hiding this comment.
I would suggest
let attributes = proto.attributes.filter {
$0.as(AttributeSyntax.self)?.attributeName.as(IdentifierTypeSyntax.self)?.name == .identifier("_spi")
}Also, you should be able to just do "(attributes)" below and shouldn’t need raw: or description or joined
There was a problem hiding this comment.
Thank you, that's nicer! Weirdly enough the == .identifier() does not compare as true, but I could do .text == "spi" to work around that.
Also removed the raw: below, thanks!
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed macro must carry forward the @_spi attribute
resolves rdar://146940405
I need to cleanup how we detect the attr;