SIL: Allow to selectively disabled cond_fails by cond_fail message #80097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard library uses `_precondition` calls which have a message argument. Allow disabling the generated cond_fail by these message arguments. For example: _precondition(source >= (0 as T), "Negative value is not representable") Results in a `cond_fail "Negative value is not representable"`. This commit allows for specifying a file that contains these messages on each line. /path/to/disable_cond_fails: ``` Negative value is not representable Array index is out of range ``` The optimizer will remove these cond_fails if the swift frontend is invoked with `-Xllvm -cond-fail-config-file=/path/to/disable_cond_fails`.
|
@swift-ci test |
eeckstein
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library uses
_preconditioncalls which have a message argument.Allow disabling the generated cond_fail by these message arguments.
For example:
results in a
cond_fail "Negative value is not representable".This commit allows for specifying a file that contains these messages on each line.
/path/to/disable_cond_fails:
The optimizer will remove these cond_fails if the swift frontend is invoked with
-Xllvm -cond-fail-config-file=/path/to/disable_cond_fails.