[cxx-interop] Determine owning module correctly for C++ decls in nested modules #80130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
hyp,
Xazax-hun,
j-hui,
fahadnayyar,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
Xazax-hun
approved these changes
Mar 19, 2025
j-hui
approved these changes
Mar 19, 2025
|
The fix looks good to me but I think a few more test cases would be valuable:
|
egorzhdan
force-pushed
the
egorzhdan/submodules-name-for-lookup
branch
from
26fbc95 to
658bcbb
Compare
|
@swift-ci please smoke test |
|
Thanks @tshortli, I added those tests. |
…ed modules This fixes a compiler bug that got exposed by llvm/llvm-project@f11abac. If a C++ type is declared in a nested Clang submodule, Swift was emitting errors that look like: ``` Type alias 'string' is not available due to missing import of defining module 'fwd’ ``` rdar://146899125
egorzhdan
force-pushed
the
egorzhdan/submodules-name-for-lookup
branch
from
658bcbb to
106a6af
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compiler bug that got exposed by llvm/llvm-project@f11abac.
If a C++ type is declared in a nested Clang submodule, Swift was emitting errors that look like:
rdar://146899125