Concurrency: remove workaround for silencing UB #80246
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
1 similar comment
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
2 similar comments
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
macOS failures: are because we gained a "memcpy" dependency: Adding "memcpy" to the allowlist of deps should resolve it. |
|
Is there a reason that these tests are macOS only? |
The newer clang properly identifies UB on invalid pointer casts. This was previously being silenced by suppressing the warnings. Adjust the code to use `std::bit_cast` (or the shim implementation) to avoid the UB in this code.
compnerd
force-pushed
the
playing-with-pointy-pointers
branch
from
ae20170 to
87f2b88
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer clang properly identifies UB on invalid pointer casts. This was previously being silenced by suppressing the warnings. Adjust the code to use
std::bit_cast(or the shim implementation) to avoid the UB in this code.