Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Remove LLVM_ENABLE_ASSERTIONS from Windows cmake cache. #80259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cmake: Remove LLVM_ENABLE_ASSERTIONS from Windows cmake cache. #80259

wants to merge 1 commit into from
+0 −8

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Mar 25, 2025

Remove LLVM_ENABLE_ASSERTIONS from the cmake Cache files for Windows. We now control this via the -Variant flag for build.ps1, and the GHA will build both variants.

@jeffdav jeffdav requested a review from compnerd as a code owner March 25, 2025 01:46
@jeffdav jeffdav mentioned this pull request Mar 25, 2025
Merged
@jeffdav
Copy link
Contributor Author

jeffdav commented Mar 25, 2025

Note: compnerd/swift-build#925 should land first.

@jeffdav jeffdav closed this Mar 25, 2025
@jeffdav jeffdav deleted the win-build-decache-assertions-flag branch March 25, 2025 17:04
@jeffdav jeffdav restored the win-build-decache-assertions-flag branch March 25, 2025 17:31
@jeffdav jeffdav reopened this Mar 25, 2025
@jeffdav
Copy link
Contributor Author

jeffdav commented Mar 26, 2025

cc: @compnerd

@compnerd
Copy link
Member

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @compnerd