-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow.rst #16841
base: 6.1
Are you sure you want to change the base?
Update workflow.rst #16841
Conversation
I don't think the Lint error is linked to my modifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why documenting parameters for only one method and not the others?
(This should target 4.4 as is)
you're right. I Will complete. |
For me it is the documentation itself that is not necessary for parameters |
I agree with your suggestion, @sebheitzmann do you want give it a try ? (on 6.3 branch). If not I can |
I will do this this week-end. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
Just a friendly ping with a new suggestion. Do you still want to update this PR? Otherwise, we can always take over and finish this one for you :)
@@ -799,6 +799,10 @@ of domain logic in your templates: | |||
|
|||
``workflow_transitions()`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would, for all functions in this list, inline the parameters in the function name:
``workflow_transitions()`` | |
``workflow_transitions(object $subject, string $name = null)`` |
I think this is the most clear and concise way of documenting them.
complete doc on twig workflow_transition function.