[Messenger] Add config option arguments for amqp delay queues
#17553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
arguments for amqp delay queues
javiereguiluz
added
the
Waiting Code Merge
|
Code merged in 7.1 |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 7, 2024
…lay queues (Thomas Beaujean) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger][Amqp] Add config option 'arguments' for delay queues | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #44186 #46254 | License | MIT | Doc PR | symfony/symfony-docs#17553 Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created. The use case: - I do not know in advance the name of the queues (handled by env variables) - The queues are created automatically by symfony if needed - I need the deduplication plugin in both the queue and the associated delays queues (enabled with the x-message-deduplication argument) - I do not want to rewrite all delay arguments, I just want to be able to add or rewrite some The associated configuration in messenger.yaml ``` transports: async: dsn: '%env(MESSENGER_DSN)%' options: queues: '%env(MESSENGER_ASYNC_QUEUE_NAME)%': arguments: x-queue-type: 'classic' x-message-deduplication: true delay: arguments: x-queue-type: 'classic' x-message-deduplication: true ``` Commits ------- 94ee8a2 [Messenger] Add config option 'arguments' for delay queues
symfony-splitter
pushed a commit
to symfony/amqp-messenger
that referenced
this pull request
Feb 7, 2024
…lay queues (Thomas Beaujean) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger][Amqp] Add config option 'arguments' for delay queues | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #44186 #46254 | License | MIT | Doc PR | symfony/symfony-docs#17553 Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created. The use case: - I do not know in advance the name of the queues (handled by env variables) - The queues are created automatically by symfony if needed - I need the deduplication plugin in both the queue and the associated delays queues (enabled with the x-message-deduplication argument) - I do not want to rewrite all delay arguments, I just want to be able to add or rewrite some The associated configuration in messenger.yaml ``` transports: async: dsn: '%env(MESSENGER_DSN)%' options: queues: '%env(MESSENGER_ASYNC_QUEUE_NAME)%': arguments: x-queue-type: 'classic' x-message-deduplication: true delay: arguments: x-queue-type: 'classic' x-message-deduplication: true ``` Commits ------- 94ee8a22b5 [Messenger] Add config option 'arguments' for delay queues
thomasbeaujean
force-pushed
the
amqp-connection-delay-arguments
branch
from
d90a84c to
85aa210
Compare
|
Hi, I rebase this doc PR on 7.1 (code merged in 7.1) |
|
@OskarStark @nicolas-grekas Has it been merged/released ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR to allow to add extra arguments to the amqp delay queues that are automatically created.