Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyInfo] Deprecate Type #20821

Open
wants to merge 3 commits into
base: 7.3
Choose a base branch
from

Conversation

MrYamous
Copy link
Contributor

Fixes #20799

@OskarStark
Copy link
Contributor

friendly ping @mtarld

@@ -303,32 +305,32 @@ Each object will provide 6 attributes, available in the 6 methods:
``Type::getBuiltInType()``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these methods are kind of removed:

  • getBuiltinType is the same as getTypeIdentifier of BuiltinType and ObjectType
  • isNullable still exists
  • getClassName only exists on ObjectType
  • isCollection is the equivalent of $type instanceof CollectionType
  • getCollection[Key|Value]Types is the same as getCollection[Key|Value]Type of CollectionType

The Type of TypeInfo is really different from the one from PropertyInfo, so I think we might rewrite that part completely.

Or maybe redirect to the doc related to TypeInfo's Type?

Copy link
Contributor Author

@MrYamous MrYamous Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed those differences.
Maybe we can remove this part from PropertyInfo Type doc as the class is deprecated and update TypeInfo doc with appropriate methods ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also not mix the TypeInfo things into the doc of PropertyInfo

Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PropertyInfo] Deprecate Type
4 participants