Makefile: update Docker image when toolchain changes #617
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnstar
approved these changes
Feb 27, 2025
kari-ts
changed the title
Update Docker image whenever we update the toolchange to force rebuild. Fixes tailscale/corp#26816 Signed-off-by: kari-ts <kari@tailscale.com>
barnstar
requested changes
Feb 27, 2025
| GO_TOOLCHAIN_REV := $(shell cat go.toolchain.rev) | ||
|
|
||
| # Define the Docker image tag using the current revision. | ||
| DOCKER_IMAGE := tailscale-android-build-amd64-$(GO_TOOLCHAIN_REV) |
There was a problem hiding this comment.
This actually won't work the way it is because we have no way of refreshing the builder when the android toolchain updates (which won't get refreshed automatically). Can we append the android toolchain here as well? That should be sufficient. Maybe toss in a constant as well, just in case we ever have to manually trigger a refresh for other reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Docker image every three months to force periodic rebuilds.
Fixes tailscale/corp#26816
Signed-off-by: kari-ts kari@tailscale.com