Skip to content

This is an experiment, not for merging. Using generated Java code instead of old interpreter code to run the parser generator" #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jurgenvinju
Copy link
Member

@jurgenvinju jurgenvinju commented Jun 2, 2025

  • replacing the interpreter that loads the parser generator and supporting modules by loading the compiled ParserGenerator and supporting modules
  • calling the right functions from the generated classes
  • fixing unexpected issues

@DavyLandman DavyLandman marked this pull request as draft June 2, 2025 11:17
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 30.92187% with 5013 lines in your changes missing coverage. Please review.

Project coverage is 43%. Comparing base (c9c9299) to head (3663d1f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/rascal/$Set.java 11% 601 Missing and 5 partials ⚠️
src/rascal/$String.java 11% 588 Missing and 12 partials ⚠️
src/rascal/$IO.java 8% 579 Missing and 1 partial ⚠️
src/rascal/util/$Math.java 5% 397 Missing and 1 partial ⚠️
src/rascal/$Map.java 9% 346 Missing and 1 partial ⚠️
src/rascal/analysis/graphs/$Graph.java 10% 320 Missing and 1 partial ⚠️
...al/lang/rascal/grammar/definition/$References.java 50% 317 Missing and 4 partials ⚠️
src/rascal/$Grammar.java 38% 250 Missing and 29 partials ⚠️
src/rascal/util/$Monitor.java 23% 232 Missing and 15 partials ⚠️
src/rascal/$Node.java 9% 230 Missing and 5 partials ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #2283      +/-   ##
==========================================
- Coverage       47%     43%      -4%     
- Complexity    6344    6485     +141     
==========================================
  Files          762     801      +39     
  Lines        62986   94371   +31385     
  Branches      9402   16930    +7528     
==========================================
+ Hits         29943   41507   +11564     
- Misses       30821   49122   +18301     
- Partials      2222    3742    +1520     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenvinju jurgenvinju marked this pull request as ready for review June 3, 2025 08:19
@jurgenvinju jurgenvinju changed the title This is an experiment, not for merging. Using generared Java code instead of old interpreter code to run the parser generator" This is an experiment, not for merging. Using generated Java code instead of old interpreter code to run the parser generator" Jun 3, 2025
@DavyLandman DavyLandman marked this pull request as draft June 26, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant