Skip to content

Rascal support for working with error trees #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Jul 3, 2025
Merged

Conversation

PieterOlivier
Copy link
Contributor

@PieterOlivier PieterOlivier commented Jun 18, 2025

This PR contains the interpreter implementation of most of the conclusions Rascal Amendment Proposal #16: Support for error trees in Rascal
The only exception is that error tree support for "indexed field assignment" is not implemented as regular indexed field assignment is not implemented in the interpreter anyway.

Parse error recovery was added to Rascal in PR #2038.
When parsing with allowRecovery=true, the resulting parse trees can contain error and skipped nodes.

Working with error trees at the appl/prod level is possible but cumbersome. This tracking PR will add better support for working with these trees.

The following pull requests contribute to this one:

@PieterOlivier PieterOlivier changed the title Rascal support for working with error trees WIP: Rascal support for working with error trees Jun 18, 2025
@DavyLandman DavyLandman marked this pull request as draft June 30, 2025 09:53
@DavyLandman DavyLandman changed the title WIP: Rascal support for working with error trees Rascal support for working with error trees Jun 30, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 87.70492% with 15 lines in your changes missing coverage. Please review.

Project coverage is 47%. Comparing base (71bea91) to head (3c74b53).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
...c/org/rascalmpl/values/parsetrees/TreeAdapter.java 71% 1 Missing and 5 partials ⚠️
...rascalmpl/values/parsetrees/ProductionAdapter.java 70% 2 Missing and 3 partials ⚠️
...almpl/interpreter/result/ConcreteSyntaxResult.java 87% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #2304    +/-   ##
========================================
  Coverage       47%     47%            
- Complexity    6368    6440    +72     
========================================
  Files          764     764            
  Lines        63194   63286    +92     
  Branches      9432    9454    +22     
========================================
+ Hits         29980   30124   +144     
+ Misses       30990   30891    -99     
- Partials      2224    2271    +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PieterOlivier PieterOlivier marked this pull request as ready for review July 3, 2025 05:59
@jurgenvinju jurgenvinju merged commit 3f6314a into main Jul 3, 2025
8 checks passed
@jurgenvinju jurgenvinju deleted the feat/error-tree-support branch July 8, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants