Skip to content

Implemented low-hanging fruit from error tree support #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PieterOlivier
Copy link
Contributor

This PR implements the following improvements:

  • is label now fails on error trees
  • tree has field now returns true if field is before the dot in an error tree
  • tree.field? now returns true if field is before the dot in an error tree
  • tree.field succeeds when field is before the dot and throws a wrapped exception when it is after the dot
  • tree.field = value succeeds when field is before the dot and throws a wrapped exception when it is after the dot
  • tree[index] now succeeds when index is before the dot and throws a wrapped exception when it is after the dot

Copy link
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I just had some suggestions for the doc strings.

@PieterOlivier PieterOlivier merged commit 13e8a1c into feat/error-tree-support Jun 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants