Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matched route accessible via Request #2104

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falbrechtskirchinger
Copy link
Contributor

Resolves #2101.

@urosg80
Copy link
Contributor

urosg80 commented Mar 15, 2025

just my thoughts but I think it would be more inline with the structure to use std::string instead of char* as there is no other pointer used in either Request or Response struct and if we would want to for the library to be more memory efficient then the whole library should move away from C++ types and move to C types; inserting one char* instead of std::string doesn't really accomplish anything IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: let the Request& know which route matched
2 participants