Add Nullable Reference Type Annotations to HtmlAgilityPack.Shared
#596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces full nullable reference type annotations to the
HtmlAgilityPack.Shared
project.!
) is used selectively where null-safety can be reasonably assumed.To support nullable annotations in older target frameworks like
.NET Framework
andnetstandard
, theNullable
NuGet package is required.I've already added this package to two projects for testing:
HtmlAgilityPack.NetStandard2_0
HtmlAgilityPack.Net35
However, I couldn't update all target projects due to missing SDKs. For the remaining ones, please run:
Feel free to merge or close.
But I hope we get this merged so feel free to suggest changes.
Null warnings not fixed: