Support disabling of string constant remapping #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/22050416/fix-issue-232
branch
from
6e070d3 to
7ab3258
Compare
Goooler
force-pushed
the
g/22050416/fix-issue-232
branch
from
5042c45 to
233e9e0
Compare
This was referenced Apr 17, 2025
Closed
# Conflicts: # src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/RelocationTest.kt
Goooler
force-pushed
the
g/22050416/fix-issue-232
branch
from
ad4a70a to
de55c7b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # api/shadow.api # docs/changes/README.md
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for disabling string constant remapping during relocation in the Shadow plugin. The feature allows users to skip relocating string literals while still relocating class names and paths, which is useful when string constants should remain unchanged even when the referenced classes are relocated.
Key changes:
- Added a new
skipStringLiteralboolean property to theRelocatorinterface andSimpleRelocatorimplementation - Modified the remapping logic to conditionally skip string literal relocation based on this flag
- Added comprehensive tests to verify the functionality works correctly
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/Relocator.kt |
Added skipStringLiteral property to the interface |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt |
Implemented skipStringLiteral property with proper equals/hashCode integration |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/RelocatorRemapper.kt |
Modified remapping logic to check skipStringLiteral flag before processing string literals |
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/RelocationTest.kt |
Added parameterized tests to verify string literal remapping can be disabled |
docs/changes/README.md |
Updated changelog with the new feature |
api/shadow.api |
Updated API definition with new property and constructor |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.