Allow APA to handle installation of GPG keys

[leggewie]

Description

as a small step to wider APA usage, we push a commit to make it discernible if a build uses APA or not -> APA_IS_ACTIVE environment variable.

In a second commit, we disable some code to be eventually deprecated that is already handled with APA's armbian-common package to handle GPG key management. This serves as a canary to give APA some exposure and testing. The environment variable APT_SIGNING_KEY is used in other places of core code and needs to be preserved regardless of the status of the APA_IS_ACTIVE var.

It is important that Armbian starts to provide a way to manage and update GPG repo keys on user devices -> armbian/apa#18

How Has This Been Tested?

Compilation was tested locally.

[coderabbitai]

"""

Walkthrough

The changes introduce an environment variable, APA_IS_ACTIVE, which is exported as "true" when the Armbian Package Archive (APA) extension is enabled. In the distro-specific root filesystem script, the logic for deploying the Armbian repository signing key is now wrapped in a conditional check that skips key deployment if APA_IS_ACTIVE is set to "true". The declaration of the APT_SIGNING_KEY_FILE variable is also moved to a fixed path earlier in the function. No public function signatures or exported entities are altered.

Possibly related PRs

• extensions: add APA extension #8133: The main PR modifies the existing APA extension by adding an environment variable export and conditional logic based on that variable, directly building upon the APA extension introduced in this PR.
• Signing key: keep a link to previous location #8282: The main PR conditionally skips the deployment of the Armbian repository signing key when APA_IS_ACTIVE is true, while this PR focuses on ensuring a symbolic link exists for the signing key file after conversion; both modify the key deployment process in the same function and involve handling the Armbian signing key files.
• lib distro-specific.sh: move armbian GPG to more common location #8128: Updates the GPG key file path to /usr/share/keyrings/armbian-archive-keyring.gpg, which aligns with the path used in the current PR.

Suggested labels

ready to merge

Suggested reviewers

• rpardini
• igorpecovnik
  """

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0998a77 and 8419661.

📒 Files selected for processing (1)

• lib/functions/rootfs/distro-specific.sh (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• lib/functions/rootfs/distro-specific.sh

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

❌ Error creating Unit Test PR.

• Create PR with Unit Tests
• Commit Unit Tests in branch wip-APA-canary-handle-GPG-keys
• Post Copyable Unit Tests in Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

lib/functions/rootfs/distro-specific.sh (1)

83-83: Scope APT_SIGNING_KEY_FILE as a local variable
Right now APT_SIGNING_KEY_FILE is global; consider making it local (e.g. local APT_SIGNING_KEY_FILE=…) to avoid leaking state outside create_sources_list_and_deploy_repo_key.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3844ef9 and 0998a77.

📒 Files selected for processing (2)

• extensions/apa.sh (1 hunks)
• lib/functions/rootfs/distro-specific.sh (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Shell script analysis

🔇 Additional comments (1)

extensions/apa.sh (1)

5-5: Export APA_IS_ACTIVE to signal APA activation
Setting APA_IS_ACTIVE="true" here correctly informs downstream scripts that APA is active.

[coderabbitai]

Note

Generated docstrings for this pull request at #8317

[coderabbitai]

Note

Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.