Skip to content

Add feature flag for using sdk password generators #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adudek-bw
Copy link

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19976

📔 Objective

Adds the feature flag constant for using the SDK to generate passwords and passphrases.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@adudek-bw adudek-bw requested a review from fedemkr July 13, 2025 17:24
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsea35b69c-b503-4c66-9830-176ec8ff62e7

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Use_Of_Hardcoded_Password /src/Core/Constants.cs: 201
detailsThe application uses the hard-coded password UseSdkPasswordGenerators for authentication purposes, either using it to verify users' identities, or...
ID: 1Y%2BZe2W9kPvb2dV%2BmkyP%2B38YTTI%3D
Attack Vector

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.06%. Comparing base (9b65e9f) to head (f6c15ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6082      +/-   ##
==========================================
- Coverage   51.48%   48.06%   -3.43%     
==========================================
  Files        1730     1730              
  Lines       76302    76302              
  Branches     6844     6844              
==========================================
- Hits        39287    36676    -2611     
- Misses      35466    38138    +2672     
+ Partials     1549     1488      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants