Skip to content

🎇 Add strictNullChecks to the tsconfig #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

ansballard
Copy link
Contributor

Currently we ignore null | undefined returns in useKV, even though the types explicitly list T | undefined as part of the return. This change surfaces that possible undefined to the user so it can be resolved by them or the agent in a visible way.

@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 17:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@ansballard
Copy link
Contributor Author

Confirmed in several fresh sparks that if you do nothing but add strictNullChecks to the tsconfig, that iterations and publishes both still work as expected. Confirmed that there can be typescript exceptions in the app and builds still succeed, because we pass --noChecks to the build command, and there is a typescript error in src/components/ui/calendar.tsx that would block any builds in sparks that use calendars. So this should be pretty safe 🚀

@ansballard ansballard merged commit 3d7da41 into main Jul 2, 2025
2 checks passed
@ansballard ansballard deleted the ansballard/workbench/strict-null-checks branch July 2, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants