-
Notifications
You must be signed in to change notification settings - Fork 19.6k
[OpenVINO Backend] support ops.slice_update #21362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[OpenVINO Backend] support ops.slice_update #21362
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21362 +/- ##
==========================================
+ Coverage 82.81% 82.82% +0.01%
==========================================
Files 565 565
Lines 55520 55571 +51
Branches 8664 8673 +9
==========================================
+ Hits 45977 46025 +48
- Misses 7428 7429 +1
- Partials 2115 2117 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
004626b
to
aef0743
Compare
let us wait until |
@rkazants |
@@ -810,9 +810,83 @@ def prepare_slice_index(val): | |||
|
|||
|
|||
def slice_update(inputs, start_indices, updates): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add comments for each block
799ecfa
to
7ef40d5
Compare
@rkazants |
307110e
to
a4188f1
Compare
9a2a8d8
to
b7c27dd
Compare
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements the slice_update
operation for the OpenVINO backend. The implementation generates indices for all elements in the updates
tensor and uses scatter_nd_update
to perform the update. The changes also enable the corresponding tests for this operation. The implementation assumes a static rank for the input tensors, and the index generation function could be refactored for better readability.
d375991
to
289ffb3
Compare
289ffb3
to
8093d51
Compare
Hi @rkazants ,
I've supported
ops,silce_update
for my GSoC project, but I can't enable tests for it until getting__getitem__
merge.It could be implemented more easily if we use
opset15
instead ofopset14
.