Skip to content

separate go mod for hack folder #21060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2025
Merged

separate go mod for hack folder #21060

merged 3 commits into from
Jul 13, 2025

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jul 11, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2025
@medyagh medyagh changed the title separate go mod for hack folder WIP: separate go mod for hack folder Jul 11, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2025
@medyagh medyagh changed the title WIP: separate go mod for hack folder separate go mod for hack folder Jul 12, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2025
@medyagh
Copy link
Member Author

medyagh commented Jul 12, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 12, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21060) |
+----------------+----------+---------------------+
| minikube start | 51.6s    | 50.8s               |
| enable ingress | 15.1s    | 15.4s               |
+----------------+----------+---------------------+

Times for minikube start: 51.2s 51.3s 50.5s 52.9s 52.0s
Times for minikube (PR 21060) start: 49.5s 51.1s 52.2s 50.6s 50.7s

Times for minikube ingress: 15.0s 15.0s 15.5s 15.0s 15.0s
Times for minikube (PR 21060) ingress: 15.5s 15.1s 15.0s 16.0s 15.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21060) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 24.3s               |
| enable ingress | 13.0s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 24.3s 23.8s 22.6s 23.0s
Times for minikube (PR 21060) start: 23.2s 26.1s 24.0s 22.8s 25.6s

Times for minikube ingress: 13.3s 13.8s 12.8s 12.8s 12.3s
Times for minikube (PR 21060) ingress: 13.3s 12.3s 13.3s 13.3s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21060) |
+----------------+----------+---------------------+
| minikube start | 21.4s    | 22.8s               |
| enable ingress | 26.3s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 21.4s 21.1s 21.4s 21.7s
Times for minikube (PR 21060) start: 23.0s 22.3s 21.1s 24.3s 23.1s

Times for minikube ingress: 22.8s 23.3s 38.8s 22.8s 23.8s
Times for minikube (PR 21060) ingress: 39.3s 39.8s 23.8s 23.3s 22.8s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 6d92b22 into kubernetes:master Jul 13, 2025
27 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants