[UI automation] Add UI tests for Peek #39818
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds UI automation tests for the Peek module to verify file preview behavior for various file types and interactions.
- Introduces a markdown checklist template for Peek tests.
- Implements UI tests in PeekFilePreviewTests.cs covering folder, image, PDF, ZIP, and QOI file previews.
- Updates the project and solution files to include the new Peek.UITests test project.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/peek/Peek.UITests/tests-checklist-template-peek.md | Adds a test checklist template for UI tests targeting Peek module. |
| src/modules/peek/Peek.UITests/PeekFilePreviewTests.cs | Implements UI tests for file preview functionality in Peek. |
| src/modules/peek/Peek.UITests/Peek.UITests.csproj | Adds project configuration for the new Peek UI tests. |
| PowerToys.sln | Registers the new Peek.UITests project in the solution. |
|
|
||
| private void VisualAssertWindow(string windowTitle) | ||
| { | ||
| VisualAssert.AreEqual(this.TestContext, this.Find(windowTitle, 500, true), "EmptyView"); |
There was a problem hiding this comment.
[nitpick] Consider defining a constant for the timeout value (500) used in assertions to improve maintainability and ease future updates.
Suggested change
| VisualAssert.AreEqual(this.TestContext, this.Find(windowTitle, 500, true), "EmptyView"); | |
| VisualAssert.AreEqual(this.TestContext, this.Find(windowTitle, AssertionTimeout, true), "EmptyView"); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed