[UX] Settings - fix header position #40160
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the drifting header in the settings page by increasing its maximum width to account for the scroll viewer’s padding.
- Introduces a new
PageHeaderMaxWidthresource set to 1020 (PageMaxWidth + 20px padding). - Updates the
HeaderTextBlock’sMaxWidthto usePageHeaderMaxWidthinstead ofPageMaxWidth.
src/settings-ui/Settings.UI/SettingsXAML/Controls/SettingsPageControl/SettingsPageControl.xaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Due to a padding in the scrollviewer hosting the settingspage content, the title drifts away upon resizing the settings window.
This PR fixes that issue by adding the (20px) padding to the maxwidth of the header textblock.
Before:
After:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed