Fix CmdPal application activation #40162
Draft
+57
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that code invoked from `MainWindow.OnActivated` is dispatched to the main (UI) thread so that `MainWindow.HandleLaunch` is always invoked on the same thread.
Prevents potential COM exceptions when accessing properties of `AppActivationArguments` that may not be initialized correctly.
jiripolasek
changed the title
This comment has been minimized.
This comment has been minimized.
… background, or settings modes This commit ensures the main application window is shown upon launch or reactivation, addressing cases where it remained hidden and caused user confusion. - Exclude visibility when started as a startup task to avoid interrupting system startup flow. - Exclude when launched with `x-cmdpal://background` URI scheme. - Exclude when launched with `x-cmdpal://settings` URI scheme.
This comment has been minimized.
This comment has been minimized.
- Add ‘CWMO’ to the spellchecker allow list to avoid flagging the acronym as a typo.
|
@zadjii-msft Hello, could you please check the PR summary and let me know if the conditions for displaying the main window are correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR:
The main window will now be automatically shown when the app is started or activated, except in the following cases:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed