Skip to content

CmdPal: make actions loading a bit more stable #40171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zadjii-msft
Copy link
Member

submitting as a draft, so that I remember to finish this in July

Mostly stashing this so I remember to come back to it next week.

I was seeing some oddities with actions failing to load on my OS build. Then I realized that if the actions fail to load, we'll reset the COM object for the runtime and re-create it. Well if GetActionsForInputs fails once, it'll probably fail the next time?

anyways, this tries to make that a wee bit more stable.

Mostly stashing this so I remember to come back to it next week.

I was seeing some oddities with actions failing to load on my OS build.
Then I realized that if the actions fail to load, we'll reset the COM
object for the runtime and re-create it. Well if GetActionsForInputs
fails once, it'll probably fail the next time?

anyways, this tries to make that a wee bit more stable.
@zadjii-msft zadjii-msft added Don't merge - Hold for release Hold off on merging this PR, even if it's approved. Product-Command Palette Refers to the Command Palette utility labels Jun 21, 2025
@crutkas crutkas removed the Don't merge - Hold for release Hold off on merging this PR, even if it's approved. label Jul 7, 2025
@zadjii-msft
Copy link
Member Author

we don't need this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants