LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250618192323088 to main #61898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
There was a problem hiding this comment.
Pull Request Overview
This PR updates diagnostic messages for dynamic imports, import assertions, import attributes, and top-level await constructs across multiple localization files to include support for the new 'node20' module flag.
- Added 'node20' to the list of valid module flag options in various diagnostic messages.
- Updated localization texts in the PLK, ITA, FRA, CHT, and CHS directories to reflect the change.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated diagnostic messages to include 'node20' in module flag options. |
| src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated Italian localization messages to include 'node20'. |
| src/loc/lcl/fra/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated French localization messages to include 'node20'. |
| src/loc/lcl/cht/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated Traditional Chinese localization messages to include 'node20'. |
| src/loc/lcl/chs/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated Simplified Chinese localization messages to include 'node20'. |
Comments suppressed due to low confidence (2)
src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl:8288
- The updated ItemId now shows a double underscore before the error code; please verify that this naming format is intentional and consistent with other identifiers.
<Item ItemId=";Import_assertions_are_only_supported_when_the_module_option_is_set_to_esnext_node18_node20_nodenext__2821" ItemType="0" PsrId="306" Leaf="true">
src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl:6026
- Ensure that the updated diagnostic message with the 'node20' option is properly documented and consistent with the corresponding changes in the tooling documentation.
<Val><![CDATA[Dynamic imports are only supported when the '--module' flag is set to 'es2020', 'es2022', 'esnext', 'commonjs', 'amd', 'system', 'umd', 'node16', 'node18', 'node20', or 'nodenext'.]]></Val>
jakebailey
approved these changes
Jun 18, 2025
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250618192323088
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250618192323088 to main with localized lcls